Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/icon-toggle-button): remove console.log #1516

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

h4de5
Copy link
Contributor

@h4de5 h4de5 commented Oct 14, 2024

💡 What is the current behavior?

When using the icon-toggle-button a console.log message is emited.

image

GitHub Issue Number: N/A

🆕 What is the new behavior?

  • console.log was removed

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

there is no logic, ui, or test related change expected - therefore none of these are applicable.

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 56589a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Oct 15, 2024

@danielleroux danielleroux merged commit ff99d8c into siemens:main Oct 15, 2024
14 of 15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants